[FSSDK-11546] holdout + decision service impl. #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaed-optimizely
requested review from
mikechu-optimizely,
muzahidul-opti and
Copilot
and removed request for
mikechu-optimizely
There was a problem hiding this comment.
Pull Request Overview
This PR adds holdout support to the Optimizely .NET SDK's decision service, enabling the SDK to evaluate holdouts (experiments that exclude users from treatment) alongside existing experiments and rollouts.
- Refactored the inheritance hierarchy to use
ExperimentCoreas the base class for both experiments and holdouts - Implemented holdout evaluation logic in the decision service with proper priority ordering (holdouts → experiments → rollouts)
- Added comprehensive test coverage for holdout functionality including bucketing, decision reasons, and user context operations
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ExperimentCore.cs | Added base class with common experiment/holdout properties and moved shared logic from Experiment class |
| Holdout.cs | Modified to override LayerId property to always return empty string as holdouts don't belong to layers |
| Experiment.cs | Removed duplicate properties now inherited from ExperimentCore |
| DecisionService.cs | Added GetDecisionForFlag method implementing holdout evaluation with proper priority ordering |
| Bucketer.cs | Updated to accept ExperimentCore instead of Experiment for holdout compatibility |
| FeatureDecision.cs | Added holdout decision source constant and updated to use ExperimentCore |
| Various other files | Updated method signatures to use ExperimentCore for holdout compatibility |
| Test files | Added comprehensive holdout test coverage including bucketing, decision service, and user context tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
junaed-optimizely
deleted the
junaed/fssdk-11546-holdout-decision-service-impl
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added holdout support in decision service.
Test plan
Tests: Comprehensive tests addition
Issues
FSSDK-11546